qgsproperty.cpp

Go to the documentation of this file.

/***************************************************************************
     qgsproperty.cpp
     ---------------
    Date                 : January 2017
    Copyright            : (C) 2017 by Nyall Dawson
    Email                : nyall dot dawson at gmail dot com
 ***************************************************************************
 *                                                                         *
 *   This program is free software; you can redistribute it and/or modify  *
 *   it under the terms of the GNU General Public License as published by  *
 *   the Free Software Foundation; either version 2 of the License, or     *
 *   (at your option) any later version.                                   *
 *                                                                         *
 ***************************************************************************/
 
#include "qgsproperty.h"
 
#include "qgsexpression.h"
#include "qgsfeature.h"
#include "qgsproperty_p.h"
#include "qgssymbollayerutils.h"
 
#include <QRegularExpression>
#include <QString>
 
using namespace Qt::StringLiterals;
 
QgsPropertyDefinition::QgsPropertyDefinition( const QString &name, const QString &description, QgsPropertyDefinition::StandardPropertyTemplate type, const QString &origin, const QString &comment )
  : mName( name )
  , mDescription( description )
  , mStandardType( type )
  , mOrigin( origin )
  , mComment( comment )
{
  switch ( mStandardType )
  {
    case Boolean:
      mTypes = DataTypeBoolean;
      mHelpText = QObject::tr( "bool [<b>1</b>=True|<b>0</b>=False]" );
      break;
 
    case Integer:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "int [≤ 0 ≥]" );
      break;
 
    case IntegerPositive:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "int [≥ 0]" );
      break;
 
    case IntegerPositiveGreaterZero:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "int [≥ 1]" );
      break;
 
    case Double:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "double [≤ 0.0 ≥]" );
      break;
 
    case DoublePositive:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "double [≥ 0.0]" );
      break;
 
    case Double0To1:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "double [0.0-1.0]" );
      break;
 
    case Rotation:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "double [0.0-360.0]" );
      break;
 
    case String:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "string of variable length" );
      break;
 
    case Opacity:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "int [0-100]" );
      break;
 
    case RenderUnits:
      mTypes = DataTypeString;
      mHelpText = trString() + u"[<b>MM</b>|<b>MapUnit</b>|<b>Pixel</b>|<b>Point</b>]"_s;
      break;
 
    case ColorWithAlpha:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "string [<b>r,g,b,a</b>] as int 0-255 or #<b>AARRGGBB</b> as hex or <b>color</b> as color's name" );
      break;
 
    case ColorNoAlpha:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "string [<b>r,g,b</b>] as int 0-255 or #<b>RRGGBB</b> as hex or <b>color</b> as color's name" );
      break;
 
    case PenJoinStyle:
      mTypes = DataTypeString;
      mHelpText = trString() + u"[<b>bevel</b>|<b>miter</b>|<b>round</b>]"_s;
      break;
 
    case BlendMode:
      mTypes = DataTypeString;
      mHelpText = trString()
                  + QStringLiteral(
                    "[<b>Normal</b>|<b>Lighten</b>|<b>Screen</b>|<b>Dodge</b>|<br>"
                    "<b>Addition</b>|<b>Darken</b>|<b>Multiply</b>|<b>Burn</b>|<b>Overlay</b>|<br>"
                    "<b>SoftLight</b>|<b>HardLight</b>|<b>Difference</b>|<b>Subtract</b>]"
                  );
      break;
 
    case Point:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "double coord [<b>X,Y</b>]" );
      break;
 
    case Size:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "double [≥ 0.0]" );
      break;
 
    case Size2D:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "string of doubles '<b>width,height</b>' or array of doubles <b>[width, height]</b>" );
      break;
 
    case LineStyle:
      mTypes = DataTypeString;
      mHelpText = trString() + u"[<b>no</b>|<b>solid</b>|<b>dash</b>|<b>dot</b>|<b>dash dot</b>|<b>dash dot dot</b>]"_s;
      break;
 
    case StrokeWidth:
      mTypes = DataTypeNumeric;
      mHelpText = QObject::tr( "double [≥ 0.0]" );
      break;
 
    case FillStyle:
      mTypes = DataTypeString;
      mHelpText = trString()
                  + QStringLiteral(
                    "[<b>solid</b>|<b>horizontal</b>|<b>vertical</b>|<b>cross</b>|<b>b_diagonal</b>|<b>f_diagonal"
                    "</b>|<b>diagonal_x</b>|<b>dense1</b>|<b>dense2</b>|<b>dense3</b>|<b>dense4</b>|<b>dense5"
                    "</b>|<b>dense6</b>|<b>dense7</b>|<b>no]"
                  );
      break;
 
    case CapStyle:
      mTypes = DataTypeString;
      mHelpText = trString() + u"[<b>square</b>|<b>flat</b>|<b>round</b>]"_s;
      break;
 
    case HorizontalAnchor:
      mTypes = DataTypeString;
      mHelpText = trString() + u"[<b>left</b>|<b>center</b>|<b>right</b>]"_s;
      break;
 
    case VerticalAnchor:
      mTypes = DataTypeString;
      mHelpText = trString() + u"[<b>top</b>|<b>center</b>|<b>bottom</b>]"_s;
      break;
 
    case SvgPath:
      mTypes = DataTypeString;
      mHelpText = trString()
                  + QStringLiteral(
                    "[<b>filepath</b>] as<br>"
                    "<b>''</b>=empty|absolute|search-paths-relative|<br>"
                    "project-relative|URL"
                  );
      break;
 
    case Offset:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "string of doubles '<b>x,y</b>' or array of doubles <b>[x, y]</b>" );
      break;
 
    case DateTime:
      mTypes = DataTypeString;
      mHelpText = QObject::tr( "DateTime or string representation of a DateTime" );
      break;
 
    case Custom:
      mTypes = DataTypeString;
  }
}
 
QgsPropertyDefinition::QgsPropertyDefinition( const QString &name, DataType dataType, const QString &description, const QString &helpText, const QString &origin, const QString &comment )
  : mName( name )
  , mDescription( description )
  , mTypes( dataType )
  , mHelpText( helpText )
  , mOrigin( origin )
  , mComment( comment )
{}
 
bool QgsPropertyDefinition::supportsAssistant() const
{
  return mTypes == DataTypeNumeric || mStandardType == Size || mStandardType == StrokeWidth || mStandardType == ColorNoAlpha || mStandardType == ColorWithAlpha || mStandardType == Rotation;
}
 
QString QgsPropertyDefinition::trString()
{
  // just something to reduce translation redundancy
  return QObject::tr( "string " );
}
 
//
// QgsProperty
//
 
QVariantMap QgsProperty::propertyMapToVariantMap( const QMap<QString, QgsProperty> &propertyMap )
{
  QVariantMap variantMap;
  QMap<QString, QgsProperty>::const_iterator it = propertyMap.constBegin();
  for ( ; it != propertyMap.constEnd(); ++it )
    variantMap.insert( it.key(), it.value().toVariant() );
  return variantMap;
}
 
QMap<QString, QgsProperty> QgsProperty::variantMapToPropertyMap( const QVariantMap &variantMap )
{
  QMap<QString, QgsProperty> propertyMap;
  QVariantMap::const_iterator it = variantMap.constBegin();
  for ( ; it != variantMap.constEnd(); ++it )
  {
    QgsProperty property;
    if ( property.loadVariant( it.value() ) )
      propertyMap.insert( it.key(), property );
  }
  return propertyMap;
}
 
QgsProperty::QgsProperty()
{
  d = new QgsPropertyPrivate();
}
 
QgsProperty::~QgsProperty() = default;
 
QgsProperty QgsProperty::fromExpression( const QString &expression, bool isActive )
{
  QgsProperty p;
  p.setExpressionString( expression );
  p.setActive( isActive );
  return p;
}
 
QgsProperty QgsProperty::fromField( const QString &fieldName, bool isActive )
{
  QgsProperty p;
  p.setField( fieldName );
  p.setActive( isActive );
  return p;
}
 
QgsProperty QgsProperty::fromValue( const QVariant &value, bool isActive )
{
  QgsProperty p;
  p.setStaticValue( value );
  p.setActive( isActive );
  return p;
}
 
QgsProperty::QgsProperty( const QgsProperty &other ) //NOLINT
  : d( other.d )
{}
 
QgsProperty &QgsProperty::operator=( const QgsProperty &other ) //NOLINT
{
  if ( &other == this )
    return *this;
 
  d = other.d;
  return *this;
}
 
bool QgsProperty::operator==( const QgsProperty &other ) const
{
  return d->active == other.d->active
         && d->type == other.d->type
         && ( d->type != Qgis::PropertyType::Static || d->staticValue == other.d->staticValue )
         && ( d->type != Qgis::PropertyType::Field || d->fieldName == other.d->fieldName )
         && ( d->type != Qgis::PropertyType::Expression || d->expressionString == other.d->expressionString )
         && ( ( !d->transformer && !other.d->transformer ) || ( d->transformer && other.d->transformer && d->transformer->toExpression( QString() ) == other.d->transformer->toExpression( QString() ) ) );
}
 
bool QgsProperty::operator!=( const QgsProperty &other ) const
{
  return ( !( ( *this ) == other ) );
}
 
Qgis::PropertyType QgsProperty::propertyType() const
{
  return d->type;
}
 
bool QgsProperty::isActive() const
{
  return d->type != Qgis::PropertyType::Invalid && d->active;
}
 
bool QgsProperty::isStaticValueInContext( const QgsExpressionContext &context, QVariant &staticValue ) const
{
  staticValue = QVariant();
  switch ( d->type )
  {
    case Qgis::PropertyType::Invalid:
      return true;
 
    case Qgis::PropertyType::Static:
      staticValue = d->staticValue;
      return true;
 
    case Qgis::PropertyType::Field:
      return false;
 
    case Qgis::PropertyType::Expression:
    {
      QgsExpression exp = d->expression;
      if ( exp.prepare( &context ) && exp.rootNode() )
      {
        if ( exp.rootNode()->hasCachedStaticValue() )
        {
          staticValue = exp.rootNode()->cachedStaticValue();
          return true;
        }
      }
      return false;
    }
  }
  return false;
}
 
void QgsProperty::setActive( bool active )
{
  d.detach();
  d->active = active;
}
 
void QgsProperty::setStaticValue( const QVariant &value )
{
  d.detach();
  d->type = Qgis::PropertyType::Static;
  d->staticValue = value;
}
 
QVariant QgsProperty::staticValue() const
{
  if ( d->type != Qgis::PropertyType::Static )
    return QVariant();
 
  return d->staticValue;
}
 
void QgsProperty::setField( const QString &field )
{
  d.detach();
  d->type = Qgis::PropertyType::Field;
  d->fieldName = field;
  d->cachedFieldIdx = -1;
}
 
QString QgsProperty::field() const
{
  if ( d->type != Qgis::PropertyType::Field )
    return QString();
 
  return d->fieldName;
}
 
QgsProperty::operator bool() const
{
  return d->type != Qgis::PropertyType::Invalid;
}
 
void QgsProperty::setExpressionString( const QString &expression )
{
  d.detach();
  d->expressionString = expression;
  d->expression = QgsExpression( expression );
  d->expressionPrepared = false;
  d->expressionIsInvalid = false;
 
  if ( d->expressionString.isEmpty() )
  {
    d->active = false;
    d->type = Qgis::PropertyType::Invalid;
  }
  else
  {
    d->type = Qgis::PropertyType::Expression;
  }
}
 
QString QgsProperty::expressionString() const
{
  if ( d->type != Qgis::PropertyType::Expression )
    return QString();
 
  return d->expressionString;
}
 
 
QString QgsProperty::asExpression() const
{
  QString exp;
  switch ( d->type )
  {
    case Qgis::PropertyType::Static:
      exp = QgsExpression::quotedValue( d->staticValue );
      break;
 
    case Qgis::PropertyType::Field:
      exp = QgsExpression::quotedColumnRef( d->fieldName );
      break;
 
    case Qgis::PropertyType::Expression:
      exp = d->expressionString;
      break;
 
    case Qgis::PropertyType::Invalid:
      exp = QString();
      break;
  }
  return d->transformer ? d->transformer->toExpression( exp ) : exp;
}
 
bool QgsProperty::prepare( const QgsExpressionContext &context ) const
{
  if ( !d->active )
    return true;
 
  switch ( d->type )
  {
    case Qgis::PropertyType::Static:
      return true;
 
    case Qgis::PropertyType::Field:
    {
      d.detach();
      // cache field index to avoid subsequent lookups
      const QgsFields f = context.fields();
      d->cachedFieldIdx = f.lookupField( d->fieldName );
      return true;
    }
 
    case Qgis::PropertyType::Expression:
    {
      d.detach();
      if ( !d->expression.prepare( &context ) )
      {
        d->expressionReferencedCols.clear();
        d->expressionPrepared = false;
        d->expressionIsInvalid = true;
        return false;
      }
 
      d->expressionPrepared = true;
      d->expressionIsInvalid = false;
      d->expressionReferencedCols = d->expression.referencedColumns();
      return true;
    }
 
    case Qgis::PropertyType::Invalid:
      return true;
  }
 
  return false;
}
 
QSet<QString> QgsProperty::referencedFields( const QgsExpressionContext &context, bool ignoreContext ) const
{
  if ( !d->active )
    return QSet<QString>();
 
  switch ( d->type )
  {
    case Qgis::PropertyType::Static:
    case Qgis::PropertyType::Invalid:
      return QSet<QString>();
 
    case Qgis::PropertyType::Field:
    {
      QSet< QString > fields;
      if ( !d->fieldName.isEmpty() )
        fields.insert( d->fieldName );
      return fields;
    }
 
    case Qgis::PropertyType::Expression:
    {
      if ( ignoreContext )
      {
        return d->expression.referencedColumns();
      }
 
      if ( d->expressionIsInvalid )
        return QSet< QString >();
 
      d.detach();
      if ( !d->expressionPrepared && !prepare( context ) )
      {
        d->expressionIsInvalid = true;
        return QSet< QString >();
      }
 
      return d->expressionReferencedCols;
    }
  }
  return QSet<QString>();
}
 
bool QgsProperty::isProjectColor() const
{
  const thread_local QRegularExpression rx( u"^project_color(_object|)\\('.*'\\)$"_s );
  return d->type == Qgis::PropertyType::Expression && !d->expressionString.isEmpty() && rx.match( d->expressionString ).hasMatch();
}
 
QVariant QgsProperty::propertyValue( const QgsExpressionContext &context, const QVariant &defaultValue, bool *ok ) const
{
  if ( ok )
    *ok = false;
 
  if ( !d->active )
    return defaultValue;
 
  switch ( d->type )
  {
    case Qgis::PropertyType::Static:
    {
      if ( ok )
        *ok = true;
      return d->staticValue;
    }
 
    case Qgis::PropertyType::Field:
    {
      const QgsFeature f = context.feature();
      if ( !f.isValid() )
        return defaultValue;
 
      //shortcut the field lookup
      if ( d->cachedFieldIdx >= 0 )
      {
        if ( ok )
          *ok = true;
        return f.attribute( d->cachedFieldIdx );
      }
      prepare( context );
      if ( d->cachedFieldIdx < 0 )
        return defaultValue;
 
      if ( ok )
        *ok = true;
      return f.attribute( d->cachedFieldIdx );
    }
 
    case Qgis::PropertyType::Expression:
    {
      if ( d->expressionIsInvalid )
        return defaultValue;
 
      if ( !d->expressionPrepared && !prepare( context ) )
        return defaultValue;
 
      QVariant result = d->expression.evaluate( &context );
      if ( !QgsVariantUtils::isNull( result ) )
      {
        if ( ok )
          *ok = true;
        return result;
      }
      else
      {
        return defaultValue;
      }
    }
 
    case Qgis::PropertyType::Invalid:
      return defaultValue;
  }
 
  return QVariant();
}
 
 
QVariant QgsProperty::value( const QgsExpressionContext &context, const QVariant &defaultValue, bool *ok ) const
{
  if ( ok )
    *ok = false;
 
  bool valOk = false;
  QVariant val = propertyValue( context, defaultValue, &valOk );
  if ( !d->transformer && !valOk ) // if transformer present, let it handle null values
    return defaultValue;
 
  if ( d->transformer )
  {
    if ( !valOk )
      val = QVariant();
    val = d->transformer->transform( context, val );
  }
 
  if ( ok )
    *ok = true;
 
  return val;
}
 
QDateTime QgsProperty::valueAsDateTime( const QgsExpressionContext &context, const QDateTime &defaultDateTime, bool *ok ) const
{
  bool valOk = false;
  const QVariant val = value( context, defaultDateTime, &valOk );
 
  if ( !valOk || QgsVariantUtils::isNull( val ) )
  {
    if ( ok )
      *ok = false;
    return defaultDateTime;
  }
 
  QDateTime dateTime;
  if ( val.userType() == QMetaType::Type::QDateTime )
  {
    dateTime = val.value<QDateTime>();
  }
  else
  {
    dateTime = val.toDateTime();
  }
 
  if ( !dateTime.isValid() )
    return defaultDateTime;
  else
  {
    if ( ok )
      *ok = true;
    return dateTime;
  }
}
 
QString QgsProperty::valueAsString( const QgsExpressionContext &context, const QString &defaultString, bool *ok ) const
{
  bool valOk = false;
  const QVariant val = value( context, defaultString, &valOk );
 
  if ( !valOk || QgsVariantUtils::isNull( val ) )
  {
    if ( ok )
      *ok = false;
    return defaultString;
  }
  else
  {
    if ( ok )
      *ok = true;
    return val.toString();
  }
}
 
QColor QgsProperty::valueAsColor( const QgsExpressionContext &context, const QColor &defaultColor, bool *ok ) const
{
  if ( ok )
    *ok = false;
 
  bool valOk = false;
  const QVariant val = value( context, defaultColor, &valOk );
 
  if ( !valOk || QgsVariantUtils::isNull( val ) )
    return defaultColor;
 
  QColor color;
  if ( val.userType() == QMetaType::Type::QColor )
  {
    color = val.value<QColor>();
  }
  else
  {
    color = QgsSymbolLayerUtils::decodeColor( val.toString() );
  }
 
  if ( !color.isValid() )
    return defaultColor;
  else
  {
    if ( ok )
      *ok = true;
    return color;
  }
}
 
double QgsProperty::valueAsDouble( const QgsExpressionContext &context, double defaultValue, bool *ok ) const
{
  if ( ok )
    *ok = false;
 
  bool valOk = false;
  const QVariant val = value( context, defaultValue, &valOk );
 
  if ( !valOk || QgsVariantUtils::isNull( val ) )
    return defaultValue;
 
  bool convertOk = false;
  const double dbl = val.toDouble( &convertOk );
  if ( !convertOk )
    return defaultValue;
  else
  {
    if ( ok )
      *ok = true;
    return dbl;
  }
}
 
int QgsProperty::valueAsInt( const QgsExpressionContext &context, int defaultValue, bool *ok ) const
{
  if ( ok )
    *ok = false;
 
  bool valOk = false;
  const QVariant val = value( context, defaultValue, &valOk );
 
  if ( !valOk || QgsVariantUtils::isNull( val ) )
    return defaultValue;
 
  bool convertOk = false;
  const int integer = val.toInt( &convertOk );
  if ( !convertOk )
  {
    //one more option to try
    const double dbl = val.toDouble( &convertOk );
    if ( convertOk )
    {
      if ( ok )
        *ok = true;
      return std::round( dbl );
    }
    else
    {
      return defaultValue;
    }
  }
  else
  {
    if ( ok )
      *ok = true;
    return integer;
  }
}
 
bool QgsProperty::valueAsBool( const QgsExpressionContext &context, bool defaultValue, bool *ok ) const
{
  if ( ok )
    *ok = false;
 
  bool valOk = false;
  const QVariant val = value( context, defaultValue, &valOk );
 
  if ( !valOk || QgsVariantUtils::isNull( val ) )
    return defaultValue;
 
  if ( ok )
    *ok = true;
  return val.toBool();
}
 
QVariant QgsProperty::toVariant() const
{
  QVariantMap propertyMap;
 
  propertyMap.insert( u"active"_s, d->active );
  propertyMap.insert( u"type"_s, static_cast< int >( d->type ) );
 
  switch ( d->type )
  {
    case Qgis::PropertyType::Static:
      // propertyMap.insert( u"valType"_s, d->staticValue.typeName() );
      propertyMap.insert( u"val"_s, d->staticValue.toString() );
      break;
 
    case Qgis::PropertyType::Field:
      propertyMap.insert( u"field"_s, d->fieldName );
      break;
 
    case Qgis::PropertyType::Expression:
      propertyMap.insert( u"expression"_s, d->expressionString );
      break;
 
    case Qgis::PropertyType::Invalid:
      break;
  }
 
  if ( d->transformer )
  {
    QVariantMap transformer;
    transformer.insert( u"t"_s, d->transformer->transformerType() );
    transformer.insert( u"d"_s, d->transformer->toVariant() );
 
    propertyMap.insert( u"transformer"_s, transformer );
  }
 
  return propertyMap;
}
 
bool QgsProperty::loadVariant( const QVariant &property )
{
  const QVariantMap propertyMap = property.toMap();
 
  d.detach();
  d->active = propertyMap.value( u"active"_s ).toBool();
  d->type = static_cast< Qgis::PropertyType >( propertyMap.value( u"type"_s, static_cast< int >( Qgis::PropertyType::Invalid ) ).toInt() );
 
  switch ( d->type )
  {
    case Qgis::PropertyType::Static:
      d->staticValue = propertyMap.value( u"val"_s );
      // d->staticValue.convert( QVariant::nameToType( propertyElem.attribute( "valType", "QString" ).toLocal8Bit().constData() ) );
      break;
 
    case Qgis::PropertyType::Field:
      d->fieldName = propertyMap.value( u"field"_s ).toString();
      if ( d->fieldName.isEmpty() )
        d->active = false;
      break;
 
    case Qgis::PropertyType::Expression:
      d->expressionString = propertyMap.value( u"expression"_s ).toString();
      if ( d->expressionString.isEmpty() )
        d->active = false;
 
      d->expression = QgsExpression( d->expressionString );
      d->expressionPrepared = false;
      d->expressionIsInvalid = false;
      d->expressionReferencedCols.clear();
      break;
 
    case Qgis::PropertyType::Invalid:
      break;
  }
 
  //restore transformer if present
  delete d->transformer;
  d->transformer = nullptr;
 
 
  const QVariant transform = propertyMap.value( u"transformer"_s );
 
  if ( transform.isValid() )
  {
    const QVariantMap transformerMap = transform.toMap();
 
    const QgsPropertyTransformer::Type type = static_cast< QgsPropertyTransformer::Type >( transformerMap.value( u"t"_s, QgsPropertyTransformer::GenericNumericTransformer ).toInt() );
    std::unique_ptr< QgsPropertyTransformer > transformer( QgsPropertyTransformer::create( type ) );
 
    if ( transformer )
    {
      if ( transformer->loadVariant( transformerMap.value( u"d"_s ) ) )
        d->transformer = transformer.release();
    }
  }
 
  return true;
}
 
 
void QgsProperty::setTransformer( QgsPropertyTransformer *transformer )
{
  d.detach();
  d->transformer = transformer;
}
 
const QgsPropertyTransformer *QgsProperty::transformer() const
{
  return d->transformer;
}
 
bool QgsProperty::convertToTransformer()
{
  if ( d->type != Qgis::PropertyType::Expression )
    return false;
 
  if ( d->transformer )
    return false; // already a transformer
 
  QString baseExpression;
  QString fieldName;
  std::unique_ptr< QgsPropertyTransformer > transformer( QgsPropertyTransformer::fromExpression( d->expressionString, baseExpression, fieldName ) );
  if ( !transformer )
    return false;
 
  d.detach();
  d->transformer = transformer.release();
  if ( !fieldName.isEmpty() )
    setField( fieldName );
  else
    setExpressionString( baseExpression );
  return true;
}