QGIS API Documentation 3.43.0-Master (e01d6d7c4c0)
qgsalgorithmfixgeometryhole.cpp
Go to the documentation of this file.
1/***************************************************************************
2 qgsalgorithmfixgeometryhole.cpp
3 ---------------------
4 begin : July 2024
5 copyright : (C) 2024 by Jacky Volpes
6 email : jacky dot volpes at oslandia dot com
7***************************************************************************/
8
9/***************************************************************************
10 * *
11 * This program is free software; you can redistribute it and/or modify *
12 * it under the terms of the GNU General Public License as published by *
13 * the Free Software Foundation; either version 2 of the License, or *
14 * (at your option) any later version. *
15 * *
16 ***************************************************************************/
17
23#include "qgsvectorlayer.h"
24#include "qgsvectorfilewriter.h"
25
27
28QString QgsFixGeometryHoleAlgorithm::name() const
29{
30 return QStringLiteral( "fixgeometryhole" );
31}
32
33QString QgsFixGeometryHoleAlgorithm::displayName() const
34{
35 return QObject::tr( "Fill holes" );
36}
37
38QString QgsFixGeometryHoleAlgorithm::shortDescription() const
39{
40 return QObject::tr( "Fills holes detected with the \"Holes\" algorithm from the \"Check geometry\" section." );
41}
42
43QStringList QgsFixGeometryHoleAlgorithm::tags() const
44{
45 return QObject::tr( "delete,fill,fix,hole" ).split( ',' );
46}
47
48QString QgsFixGeometryHoleAlgorithm::group() const
49{
50 return QObject::tr( "Fix geometry" );
51}
52
53QString QgsFixGeometryHoleAlgorithm::groupId() const
54{
55 return QStringLiteral( "fixgeometry" );
56}
57
58QString QgsFixGeometryHoleAlgorithm::shortHelpString() const
59{
60 return QObject::tr( "This algorithm deletes holes based on an error layer from the \"Holes\" algorithm in the \"Check geometry\" section.\n" );
61}
62
63QgsFixGeometryHoleAlgorithm *QgsFixGeometryHoleAlgorithm::createInstance() const
64{
65 return new QgsFixGeometryHoleAlgorithm();
66}
67
68void QgsFixGeometryHoleAlgorithm::initAlgorithm( const QVariantMap &configuration )
69{
70 Q_UNUSED( configuration )
71
72 // Inputs
74 QStringLiteral( "INPUT" ), QObject::tr( "Input layer" ), QList<int>() << static_cast<int>( Qgis::ProcessingSourceType::VectorPolygon ) << static_cast<int>( Qgis::ProcessingSourceType::VectorLine )
75 ) );
77 QStringLiteral( "ERRORS" ), QObject::tr( "Error layer" ), QList<int>() << static_cast<int>( Qgis::ProcessingSourceType::VectorPoint )
78 ) );
79 addParameter( new QgsProcessingParameterField(
80 QStringLiteral( "UNIQUE_ID" ), QObject::tr( "Field of original feature unique identifier" ),
81 QStringLiteral( "id" ), QStringLiteral( "ERRORS" )
82 ) );
83 addParameter( new QgsProcessingParameterField(
84 QStringLiteral( "PART_IDX" ), QObject::tr( "Field of part index" ),
85 QStringLiteral( "gc_partidx" ), QStringLiteral( "ERRORS" ),
87 ) );
88 addParameter( new QgsProcessingParameterField(
89 QStringLiteral( "RING_IDX" ), QObject::tr( "Field of ring index" ),
90 QStringLiteral( "gc_ringidx" ), QStringLiteral( "ERRORS" ),
92 ) );
93 addParameter( new QgsProcessingParameterField(
94 QStringLiteral( "VERTEX_IDX" ), QObject::tr( "Field of vertex index" ),
95 QStringLiteral( "gc_vertidx" ), QStringLiteral( "ERRORS" ),
97 ) );
98
99 // Outputs
100 addParameter( new QgsProcessingParameterFeatureSink(
101 QStringLiteral( "OUTPUT" ), QObject::tr( "Holes-filled layer" ), Qgis::ProcessingSourceType::VectorAnyGeometry
102 ) );
103 addParameter( new QgsProcessingParameterFeatureSink(
104 QStringLiteral( "REPORT" ), QObject::tr( "Report layer from fixing holes" ), Qgis::ProcessingSourceType::VectorPoint
105 ) );
106
107 std::unique_ptr<QgsProcessingParameterNumber> tolerance = std::make_unique<QgsProcessingParameterNumber>(
108 QStringLiteral( "TOLERANCE" ), QObject::tr( "Tolerance" ), Qgis::ProcessingNumberParameterType::Integer, 8, false, 1, 13
109 );
110 tolerance->setFlags( tolerance->flags() | Qgis::ProcessingParameterFlag::Advanced );
111 tolerance->setHelp( QObject::tr( "The \"Tolerance\" advanced parameter defines the numerical precision of geometric operations, "
112 "given as an integer n, meaning that any difference smaller than 10⁻ⁿ (in map units) is considered zero." ) );
113 addParameter( tolerance.release() );
114}
115
116QVariantMap QgsFixGeometryHoleAlgorithm::processAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback )
117{
118 const std::unique_ptr<QgsProcessingFeatureSource> input( parameterAsSource( parameters, QStringLiteral( "INPUT" ), context ) );
119 if ( !input )
120 throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "INPUT" ) ) );
121
122 const std::unique_ptr<QgsProcessingFeatureSource> errors( parameterAsSource( parameters, QStringLiteral( "ERRORS" ), context ) );
123 if ( !errors )
124 throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "ERRORS" ) ) );
125
126 QgsProcessingMultiStepFeedback multiStepFeedback( 2, feedback );
127
128 const QString featIdFieldName = parameterAsString( parameters, QStringLiteral( "UNIQUE_ID" ), context );
129 const QString partIdxFieldName = parameterAsString( parameters, QStringLiteral( "PART_IDX" ), context );
130 const QString ringIdxFieldName = parameterAsString( parameters, QStringLiteral( "RING_IDX" ), context );
131 const QString vertexIdxFieldName = parameterAsString( parameters, QStringLiteral( "VERTEX_IDX" ), context );
132
133 // Verify that input fields exists
134 if ( errors->fields().indexFromName( featIdFieldName ) == -1 )
135 throw QgsProcessingException( QObject::tr( "Field %1 does not exist in the error layer." ).arg( featIdFieldName ) );
136 if ( errors->fields().indexFromName( partIdxFieldName ) == -1 )
137 throw QgsProcessingException( QObject::tr( "Field %1 does not exist in the error layer." ).arg( partIdxFieldName ) );
138 if ( errors->fields().indexFromName( ringIdxFieldName ) == -1 )
139 throw QgsProcessingException( QObject::tr( "Field %1 does not exist in the error layer." ).arg( ringIdxFieldName ) );
140 if ( errors->fields().indexFromName( vertexIdxFieldName ) == -1 )
141 throw QgsProcessingException( QObject::tr( "Field %1 does not exist in the error layer." ).arg( vertexIdxFieldName ) );
142 int inputIdFieldIndex = input->fields().indexFromName( featIdFieldName );
143 if ( inputIdFieldIndex == -1 )
144 throw QgsProcessingException( QObject::tr( "Field %1 does not exist in input layer." ).arg( featIdFieldName ) );
145
146 QgsField inputFeatIdField = input->fields().at( inputIdFieldIndex );
147 if ( inputFeatIdField.type() != errors->fields().at( errors->fields().indexFromName( featIdFieldName ) ).type() )
148 throw QgsProcessingException( QObject::tr( "Field %1 does not have the same type as in the error layer." ).arg( featIdFieldName ) );
149
150 QString dest_output;
151 const std::unique_ptr<QgsFeatureSink> sink_output( parameterAsSink( parameters, QStringLiteral( "OUTPUT" ), context, dest_output, input->fields(), input->wkbType(), input->sourceCrs() ) );
152 if ( !sink_output )
153 throw QgsProcessingException( invalidSinkError( parameters, QStringLiteral( "OUTPUT" ) ) );
154
155 QString dest_report;
156 QgsFields reportFields = errors->fields();
157 reportFields.append( QgsField( QStringLiteral( "report" ), QMetaType::QString ) );
158 reportFields.append( QgsField( QStringLiteral( "error_fixed" ), QMetaType::Bool ) );
159 const std::unique_ptr<QgsFeatureSink> sink_report( parameterAsSink( parameters, QStringLiteral( "REPORT" ), context, dest_report, reportFields, errors->wkbType(), errors->sourceCrs() ) );
160 if ( !sink_report )
161 throw QgsProcessingException( invalidSinkError( parameters, QStringLiteral( "REPORT" ) ) );
162
163 const QgsProject *project = QgsProject::instance();
164 QgsGeometryCheckContext checkContext = QgsGeometryCheckContext( mTolerance, input->sourceCrs(), project->transformContext(), project );
165 QStringList messages;
166
167 const QgsGeometryHoleCheck check( &checkContext, QVariantMap() );
168
169 std::unique_ptr<QgsVectorLayer> fixedLayer( input->materialize( QgsFeatureRequest() ) );
171 QMap<QString, QgsFeaturePool *> featurePools;
172 featurePools.insert( fixedLayer->id(), &featurePool );
173
174 QgsFeature errorFeature, inputFeature, testDuplicateIdFeature;
175 QgsFeatureIterator errorFeaturesIt = errors->getFeatures();
176 QList<QgsGeometryCheck::Changes> changesList;
177 QgsFeature reportFeature;
178 reportFeature.setFields( reportFields );
179 long long progression = 0;
180 long long totalProgression = errors->featureCount();
181 multiStepFeedback.setCurrentStep( 1 );
182 multiStepFeedback.setProgressText( QObject::tr( "Fixing errors..." ) );
183 while ( errorFeaturesIt.nextFeature( errorFeature ) )
184 {
185 if ( feedback->isCanceled() )
186 break;
187
188 progression++;
189 multiStepFeedback.setProgress( static_cast<double>( static_cast<long double>( progression ) / totalProgression ) * 100 );
190 reportFeature.setGeometry( errorFeature.geometry() );
191
192 QString idValue = errorFeature.attribute( featIdFieldName ).toString();
193 if ( inputFeatIdField.type() == QMetaType::QString )
194 idValue = "'" + idValue + "'";
195
196 QgsFeatureIterator it = fixedLayer->getFeatures( QgsFeatureRequest().setFilterExpression( "\"" + featIdFieldName + "\" = " + idValue ) );
197 if ( !it.nextFeature( inputFeature ) || !inputFeature.isValid() )
198 reportFeature.setAttributes( errorFeature.attributes() << QObject::tr( "Source feature not found or invalid" ) << false );
199
200 else if ( it.nextFeature( testDuplicateIdFeature ) )
201 throw QgsProcessingException( QObject::tr( "More than one feature found in input layer with value %1 in unique field %2" ).arg( idValue ).arg( featIdFieldName ) );
202
203 else if ( inputFeature.geometry().isNull() )
204 reportFeature.setAttributes( errorFeature.attributes() << QObject::tr( "Feature geometry is null" ) << false );
205
206 else if ( QgsGeometryCheckerUtils::getGeomPart( inputFeature.geometry().constGet(), errorFeature.attribute( partIdxFieldName ).toInt() ) == nullptr )
207 reportFeature.setAttributes( errorFeature.attributes() << QObject::tr( "Feature geometry part is null" ) << false );
208
209 else
210 {
212 &check,
213 QgsGeometryCheckerUtils::LayerFeature( &featurePool, inputFeature, &checkContext, false ),
214 errorFeature.geometry().asPoint(),
216 errorFeature.attribute( partIdxFieldName ).toInt(),
217 errorFeature.attribute( ringIdxFieldName ).toInt(),
218 errorFeature.attribute( vertexIdxFieldName ).toInt()
219 )
220 );
221 for ( auto changes : changesList )
222 checkError.handleChanges( changes );
223
225 check.fixError( featurePools, &checkError, QgsGeometryHoleCheck::ResolutionMethod::RemoveHoles, QMap<QString, int>(), changes );
226 changesList << changes;
227
228 QString resolutionMessage = checkError.resolutionMessage();
229 if ( checkError.status() == QgsGeometryCheckError::StatusObsolete )
230 resolutionMessage = QObject::tr( "Error is obsolete" );
231
232 reportFeature.setAttributes( errorFeature.attributes() << resolutionMessage << ( checkError.status() == QgsGeometryCheckError::StatusFixed ) );
233 }
234
235 if ( !sink_report->addFeature( reportFeature, QgsFeatureSink::FastInsert ) )
236 throw QgsProcessingException( writeFeatureError( sink_report.get(), parameters, QStringLiteral( "REPORT" ) ) );
237 }
238 multiStepFeedback.setProgress( 100 );
239
240 progression = 0;
241 totalProgression = fixedLayer->featureCount();
242 multiStepFeedback.setCurrentStep( 2 );
243 multiStepFeedback.setProgressText( QObject::tr( "Exporting fixed layer..." ) );
244 QgsFeature fixedFeature;
245 QgsFeatureIterator fixedFeaturesIt = fixedLayer->getFeatures();
246 while ( fixedFeaturesIt.nextFeature( fixedFeature ) )
247 {
248 if ( feedback->isCanceled() )
249 break;
250
251 progression++;
252 multiStepFeedback.setProgress( static_cast<double>( static_cast<long double>( progression ) / totalProgression ) * 100 );
253 if ( !sink_output->addFeature( fixedFeature, QgsFeatureSink::FastInsert ) )
254 throw QgsProcessingException( writeFeatureError( sink_output.get(), parameters, QStringLiteral( "OUTPUT" ) ) );
255 }
256 multiStepFeedback.setProgress( 100 );
257
258 QVariantMap outputs;
259 outputs.insert( QStringLiteral( "OUTPUT" ), dest_output );
260 outputs.insert( QStringLiteral( "REPORT" ), dest_report );
261
262 return outputs;
263}
264
265bool QgsFixGeometryHoleAlgorithm::prepareAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback * )
266{
267 mTolerance = parameterAsInt( parameters, QStringLiteral( "TOLERANCE" ), context );
268
269 return true;
270}
271
272Qgis::ProcessingAlgorithmFlags QgsFixGeometryHoleAlgorithm::flags() const
273{
275}
276
@ VectorAnyGeometry
Any vector layer with geometry.
@ VectorPoint
Vector point layers.
@ VectorPolygon
Vector polygon layers.
@ VectorLine
Vector line layers.
@ Numeric
Accepts numeric fields.
QFlags< ProcessingAlgorithmFlag > ProcessingAlgorithmFlags
Flags indicating how and when an algorithm operates and should be exposed to users.
Definition qgis.h:3476
@ NoThreading
Algorithm is not thread safe and cannot be run in a background thread, e.g. for algorithms which mani...
@ Advanced
Parameter is an advanced parameter which should be hidden from users by default.
Wrapper for iterator of features from vector data provider or vector layer.
bool nextFeature(QgsFeature &f)
Fetch next feature and stores in f, returns true on success.
Wraps a request for features to a vector layer (or directly its vector data provider).
@ FastInsert
Use faster inserts, at the cost of updating the passed features to reflect changes made at the provid...
The feature class encapsulates a single feature including its unique ID, geometry and a list of field...
Definition qgsfeature.h:58
QgsAttributes attributes
Definition qgsfeature.h:67
void setAttributes(const QgsAttributes &attrs)
Sets the feature's attributes.
void setFields(const QgsFields &fields, bool initAttributes=false)
Assigns a field map with the feature to allow attribute access by attribute name.
QgsGeometry geometry
Definition qgsfeature.h:69
bool isValid() const
Returns the validity of this feature.
Q_INVOKABLE QVariant attribute(const QString &name) const
Lookup attribute value by attribute name.
void setGeometry(const QgsGeometry &geometry)
Set the feature's geometry.
bool isCanceled() const
Tells whether the operation has been canceled already.
Definition qgsfeedback.h:53
Encapsulate a field in an attribute table or data source.
Definition qgsfield.h:53
QMetaType::Type type
Definition qgsfield.h:60
Container of fields for a vector layer.
Definition qgsfields.h:46
bool append(const QgsField &field, Qgis::FieldOrigin origin=Qgis::FieldOrigin::Provider, int originIndex=-1)
Appends a field.
Definition qgsfields.cpp:70
Base configuration for geometry checks.
This represents an error reported by a geometry check.
@ StatusFixed
The error is fixed.
@ StatusObsolete
The error is obsolete because of other modifications.
Status status() const
The status of the error.
QString resolutionMessage() const
A message with details, how the error has been resolved.
QMap< QString, QMap< QgsFeatureId, QList< QgsGeometryCheck::Change > > > Changes
A collection of changes.
A layer feature combination to uniquely identify and access a feature in a set of layers.
static QgsAbstractGeometry * getGeomPart(QgsAbstractGeometry *geom, int partIdx)
const QgsAbstractGeometry * constGet() const
Returns a non-modifiable (const) reference to the underlying abstract geometry primitive.
QgsPointXY asPoint() const
Returns the contents of the geometry as a 2-dimensional point.
virtual Qgis::ProcessingAlgorithmFlags flags() const
Returns the flags indicating how and when the algorithm operates and should be exposed to users.
Contains information about the context in which a processing algorithm is executed.
Custom exception class for processing related exceptions.
Base class for providing feedback from a processing algorithm.
Processing feedback object for multi-step operations.
A feature sink output for processing algorithms.
An input feature source (such as vector layers) parameter for processing algorithms.
A vector layer or feature source field parameter for processing algorithms.
Encapsulates a QGIS project, including sets of map layers and their styles, layouts,...
Definition qgsproject.h:107
static QgsProject * instance()
Returns the QgsProject singleton instance.
QgsCoordinateTransformContext transformContext
Definition qgsproject.h:113
A feature pool based on a vector data provider.
Utility class for identifying a unique vertex within a geometry.
Definition qgsvertexid.h:30